kayjaydee/portfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(01): address checker revision issues

Browse Source 
- Mark RESEARCH.md Open Questions as RESOLVED with decisions
- Fix Plan 01-02 Task 1 verify to be independent of Task 2 (file existence + grep check instead of typecheck)
- Strengthen negative criterion: all app/data/ files must NOT contain @/assets/images/
This commit is contained in:
MrKayJayDee
2026-04-07 23:45:00 +02:00
parent f1e31fc043
commit 1704da8ce5
2 changed files with 476 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.planning/phases/01-foundation/01-02-PLAN.md
+6 -6
View File
@@ -298,7 +298,7 @@ export interface FAQ {
Remplacement a effectuer: `@/assets/images/` -> `/images/` pour CHAQUE entree (60+ images).
</action>
<verify>
<automated>cd C:/Users/minit/Desktop/portfolio/portfolio && npx nuxi typecheck 2>&1 | tail -5</automated>
<automated>cd C:/Users/minit/Desktop/portfolio/portfolio && node -e "const fs=require('fs'); const files=['app/data/projects.ts','app/data/testimonials.ts','app/data/faq.ts','app/data/techstack.ts']; let ok=true; for(const f of files){if(!fs.existsSync(f)){console.log('MISSING: '+f);ok=false;}else{const c=fs.readFileSync(f,'utf8');if(c.includes('@/assets/images/')){console.log('FAIL: '+f+' still contains @/assets/images/');ok=false;}}} if(!fs.existsSync('public/images')){console.log('MISSING: public/images/');ok=false;} console.log(ok?'PASS':'FAIL');"</automated>
</verify>
<acceptance_criteria>
- app/data/projects.ts contains `export const projects: Project[]`
@@ -309,12 +309,12 @@ export interface FAQ {
- app/data/faq.ts contains `export const homeFAQs: FAQ[]`
- app/data/faq.ts contains `questionKey:` (i18n keys, not direct text)
- app/data/techstack.ts contains `export const techStack: TechStack`
- app/data/techstack.ts contains `/images/javascript.webp` (not `@/assets/images/`)
- public/images/ directory contains .webp files
- app/data/techstack.ts does NOT contain `@/assets/images/` (all paths migrated)
- app/data/projects.ts does NOT contain `@/assets/images/` (all paths migrated)
- No file in app/data/ contains `@/assets/images/`
- npx nuxi typecheck exits with code 0
- public/images/ directory contains .webp files
</acceptance_criteria>
<done>4 fichiers data migres avec types corrects, images dans public/images/, aucune reference a @/assets/images/</done>
<done>4 fichiers data migres avec types corrects, images dans public/images/, aucune reference a @/assets/images/ dans aucun fichier app/data/</done>
</task>
<task type="auto">
@@ -353,7 +353,7 @@ export function useProjects() {
)
}
function search(query: Ref&lt;string&gt; | string) {
function search(query: Ref<string> | string) {
return computed(() => {
const q = typeof query === 'string' ? query : query.value
if (!q) return projects.value